EnterPasswordController and associated cleanup#9656
Merged
soniaconnolly merged 14 commits intomainfrom Nov 25, 2023
Merged
Conversation
…firmed_at attribute
The method was only used in PhoneSetupController, so move method & private method there and stop including this where it is not used.
… user_session idv_session should always be available in EnterPasswordController and PersonalKeyController. This indirection is probably left over from FSM days.
Co-authored-by: Matt Hinz <matt.hinz@gsa.gov>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
While working on LG-11463 we noticed a lot of needed cleanup for EnterPasswordController and controller specs, so we're making a separate branch. See commits for specific cleanups.
📜 Testing Plan
Run specs.