Skip to content

LG-11463 Don't delete pii_from_doc and pii_from_user on VerifyInfo submission #9645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
soniaconnolly merged 3 commits into from
Nov 22, 2023
Merged

LG-11463 Don't delete pii_from_doc and pii_from_user on VerifyInfo submission #9645

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
19d77d3
Don't delete pii_from_doc and pii_from_user on VerifyInfo submission
soniaconnolly Nov 22, 2023
ee1a120
Allow :same_address_as_id to be logged in proofing results now that :…
soniaconnolly Nov 22, 2023
e53f3b7
Don't repeat the start of the flow in verify_info specs, hoping they'…
soniaconnolly Nov 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions app/controllers/concerns/idv/verify_info_concern.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -315,14 +315,6 @@ def move_applicant_to_idv_session
idv_session.applicant = pii
idv_session.applicant[:ssn] = idv_session.ssn
idv_session.applicant['uuid'] = current_user.uuid
delete_pii
end

def delete_pii
idv_session.pii_from_doc = nil
if defined?(flow_session) # no longer defined for remote flow
flow_session.delete(:pii_from_user)
end
end

def add_proofing_costs(results)
Expand Down
2 changes: 1 addition & 1 deletion spec/features/idv/analytics_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -412,7 +412,7 @@
analytics_id: 'In Person Proofing', step: 'verify', flow_path: 'standard', irs_reproofing: false, same_address_as_id: false, getting_started_ab_test_bucket: :welcome_default, phone_question_ab_test_bucket: :bypass_phone_question, phone_with_camera: nil, acuant_sdk_upgrade_ab_test_bucket: :default, skip_hybrid_handoff: nil
},
'IdV: doc auth verify proofing results' => {
success: true, errors: {}, flow_path: 'standard', address_edited: false, address_line2_present: false, analytics_id: 'In Person Proofing', ssn_is_unique: true, step: 'verify', acuant_sdk_upgrade_ab_test_bucket: :default, getting_started_ab_test_bucket: :welcome_default, phone_question_ab_test_bucket: :bypass_phone_question, phone_with_camera: nil, irs_reproofing: false, skip_hybrid_handoff: nil,
success: true, errors: {}, flow_path: 'standard', address_edited: false, address_line2_present: false, analytics_id: 'In Person Proofing', ssn_is_unique: true, step: 'verify', acuant_sdk_upgrade_ab_test_bucket: :default, getting_started_ab_test_bucket: :welcome_default, phone_question_ab_test_bucket: :bypass_phone_question, phone_with_camera: nil, irs_reproofing: false, same_address_as_id: false, skip_hybrid_handoff: nil,
Copy link
Copy Markdown
Contributor

@gina-yamada gina-yamada Nov 22, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Walked through this with Sonia. pii_from_user was deleted so same_address_as_id never got added via extra_analytics_properties. This change makes sense to me

proofing_results: { exception: nil, timed_out: false, threatmetrix_review_status: 'pass', context: { device_profiling_adjudication_reason: 'device_profiling_result_pass', resolution_adjudication_reason: 'pass_resolution_and_state_id', should_proof_state_id: true, stages: { resolution: { success: true, errors: {}, exception: nil, timed_out: false, transaction_id: 'resolution-mock-transaction-id-123', reference: 'aaa-bbb-ccc', can_pass_with_additional_verification: false, attributes_requiring_additional_verification: [], vendor_name: 'ResolutionMock', vendor_workflow: nil }, residential_address: { errors: {}, exception: nil, reference: 'aaa-bbb-ccc', success: true, timed_out: false, transaction_id: 'resolution-mock-transaction-id-123', can_pass_with_additional_verification: false, attributes_requiring_additional_verification: [], vendor_name: 'ResolutionMock', vendor_workflow: nil }, state_id: { success: true, errors: {}, exception: nil, mva_exception: nil, timed_out: false, transaction_id: 'state-id-mock-transaction-id-456', vendor_name: 'StateIdMock', verified_attributes: [], state: 'MT', state_id_jurisdiction: 'ND', state_id_number: '#############' }, threatmetrix: threatmetrix_response } } }
},
'IdV: phone confirmation form' => {
Expand Down
6 changes: 2 additions & 4 deletions spec/features/idv/doc_auth/verify_info_step_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -350,8 +350,7 @@

context 'async missing' do
it 'allows resubmitting form' do
sign_in_and_2fa_user(user)
complete_doc_auth_steps_before_verify_step
complete_ssn_step

allow(DocumentCaptureSession).to receive(:find_by).
and_return(nil)
Expand Down Expand Up @@ -386,8 +385,7 @@

context 'async timed out' do
it 'allows resubmitting form' do
sign_in_and_2fa_user(user)
complete_doc_auth_steps_before_verify_step
complete_ssn_step

allow(DocumentCaptureSession).to receive(:find_by).
and_return(nil)
Expand Down