Skip to content

Remove GpoExpirationJob::initialize#9641

Merged
matthinz merged 3 commits intomainfrom
matthinz/fix-gpo-expiration-initialize
Nov 24, 2023
Merged

Remove GpoExpirationJob::initialize#9641
matthinz merged 3 commits intomainfrom
matthinz/fix-gpo-expiration-initialize

Conversation

@matthinz
Copy link
Contributor

@matthinz matthinz commented Nov 22, 2023

GpoExpirationJob, added in #9545 and enabled in #9622, is raising a NoMethodError when it's run via good_job. This is due to the initializer missing a super call.

This PR removes the initialize method.

Need to include *args and **rest on here so that required args get passed down to ApplicationJob.

[skip changelog]
@matthinz matthinz changed the title Fix GpoExpirationJob::initialize Remove GpoExpirationJob::initialize Nov 22, 2023
@matthinz matthinz merged commit 290cbe5 into main Nov 24, 2023
@matthinz matthinz deleted the matthinz/fix-gpo-expiration-initialize branch November 24, 2023 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants