Merged
Conversation
jc-gsa
force-pushed
the
LG-11287-reauth-pages
branch
from
5e2a914 to
1e769da
Compare
changelog: User-Facing Improvements, Authentication, Update reauthentication user notice
jc-gsa
force-pushed
the
LG-11287-reauth-pages
branch
from
1e769da to
5aedd0f
Compare
kevinsmaster5
approved these changes
Nov 21, 2023
Contributor
kevinsmaster5
left a comment
kevinsmaster5
left a comment
There was a problem hiding this comment.
It looks good! Validated output locally. 👍
aduth
approved these changes
Nov 21, 2023
Comment on lines
-31
to
+43
| t('two_factor_authentication.login_options_title') | ||
| if reauthentication_context? | ||
| t('two_factor_authentication.login_options_reauthentication_title') | ||
| else | ||
| t('two_factor_authentication.login_options_title') | ||
| end | ||
| end | ||
|
|
||
| def info | ||
| t('two_factor_authentication.login_intro') | ||
| if reauthentication_context? | ||
| t('two_factor_authentication.login_intro_reauthentication') | ||
| else | ||
| t('two_factor_authentication.login_intro') | ||
| end |
Contributor
There was a problem hiding this comment.
For completeness, can we add some test coverage for this logic in spec/presenters/two_factor_login_options_presenter_spec.rb ?
mdiarra3
approved these changes
Nov 21, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
LG-11287
🛠 Summary of changes
Changes content at the page
/login/two_factor/optionswhen the reauthentication window expires.