LG-11569: Add feature flag for reorienting SDK capture#9624
Merged
night-jellyfish merged 2 commits intomainfrom Nov 22, 2023
Merged
LG-11569: Add feature flag for reorienting SDK capture#9624night-jellyfish merged 2 commits intomainfrom
night-jellyfish merged 2 commits intomainfrom
Conversation
night-jellyfish
requested review from
a team and
dawei-nava
and removed request for
a team
dawei-nava
reviewed
Nov 20, 2023
amirbey
approved these changes
Nov 20, 2023
added 2 commits
November 22, 2023 11:09
I used this format for the flag because we want to be able to split the number of users who see horizontal or vertical.
night-jellyfish
force-pushed
the
brittany/lg-11569-reorient-sdk-capture-feature-flag
branch
from
c5205fe to
8ab98fd
Compare
night-jellyfish
deleted the
brittany/lg-11569-reorient-sdk-capture-feature-flag
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
LG-11569
🛠 Summary of changes
Adding a feature flag to control whether users see the horizontal or vertical version of the SDK. This change just sets up the feature flag for future work.
I used this format for the flag because we want to be able to split the
number of users who see horizontal or vertical.
📜 Testing Plan
IdentityConfig.store.doc_auth_sdk_capture_orientation{:horizontal=>100, :vertical=>0}👀 Screenshots
If relevant, include a screenshot or screen capture of the changes.
Before:
After: