Skip to content

LG-11439 Opt-in IPP: redirect if agreement step not completed#9615

Merged
svalexander merged 2 commits intomainfrom
shannon/lg-11439-opt-in-redirect
Nov 21, 2023
Merged

LG-11439 Opt-in IPP: redirect if agreement step not completed#9615
svalexander merged 2 commits intomainfrom
shannon/lg-11439-opt-in-redirect

Conversation

@svalexander
Copy link
Contributor

@svalexander svalexander commented Nov 17, 2023

🎫 Ticket

LG-11439

🛠 Summary of changes

On how to verify page check that agreement step has been completed. If it hasn't the user will now be redirected back to the agreement page.

📜 Testing Plan

Provide a checklist of steps to confirm the changes.

  • Set in_person_residential_address_controller_enabled flag to true
  • Create an account and arrive at /agreement
  • Do not check the box
  • Change url to /verify/how_to_verify
  • Confirm that you are redirected back to /agreement
  • Check the box
  • Click continue
  • Confirm that you are directed to /how_to_verify

@svalexander svalexander requested review from a team and allthesignals November 17, 2023 16:59
@JackRyan1989
Copy link
Contributor

@svalexander I am not getting redirected to verify/how_to_verify/ when I click 'Continue' after checking the box. I'm ending up at /verify/hybrid_handoff

@svalexander
Copy link
Contributor Author

@svalexander I am not getting redirected to verify/how_to_verify/ when I click 'Continue' after checking the box. I'm ending up at /verify/hybrid_handoff

Do you have this flag set to true: in_person_proofing_opt_in_enabled ? It should be going to /hybrid_handoff if that flag is false and going to /how_to_verify if it's true

Copy link
Contributor

@JackRyan1989 JackRyan1989 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

self.enabled?
self.enabled? && idv_session.idv_consent_given
end,
undo_step: ->(idv_session:, user:) {}, # clear any saved data
Copy link
Contributor

@soniaconnolly soniaconnolly Nov 20, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR looks good, and you could go ahead and add idv_session.skip_doc_auth = nil for undo_step.

Edit: You also need before_action :confirm_document_capture_not_complete at the top.
Edit again: Gina and I added these two things on her PR.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@svalexander I will take care of this. In PR # 9598, I am setting the value so I think it makes sense to unset it in the same PR.

@svalexander svalexander merged commit 2afb1de into main Nov 21, 2023
@svalexander svalexander deleted the shannon/lg-11439-opt-in-redirect branch November 21, 2023 13:10
mitchellhenke pushed a commit that referenced this pull request Nov 21, 2023
* check agreement is completed

* changelog: Upcoming Features, How to verify, redirect when prev step incomplete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants