Switch put_pii to keyword arguments#9605
Merged
zachmargolis merged 1 commit intomainfrom Nov 15, 2023
Merged
Conversation
**Why**: Provides additional clarity, makes it harder to mix up than ordered arguments changelog: Internal, Source code, Refactor source code
soniaconnolly
approved these changes
Nov 15, 2023
Contributor
soniaconnolly
left a comment
soniaconnolly
left a comment
There was a problem hiding this comment.
Looks good! Sometimes keyword args seem like lots of extra typing, but it sure reads better.
Contributor
Author
luckily we don't have a character quota ;) ;) |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implementing my own post-hoc suggestion in previous PR #9596 (comment)
Why: Provides additional clarity, makes it harder to mix up than ordered arguments
(peer-reviewed version of 8240c4b, which was reverted in #9604)