Start writing idv_session.personal_key_acknowledged#9595
Merged
Conversation
soniaconnolly
approved these changes
Nov 15, 2023
Contributor
soniaconnolly
left a comment
soniaconnolly
left a comment
There was a problem hiding this comment.
LGTM, one suggestion
We don't currently track that the user has acknowledged their personal key. [skip changelog]
We mean it!
matthinz
force-pushed
the
matthinz/record-personal-key-ack-in-idv-session
branch
from
c892e12 to
4607694
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We currently track that the user has viewed / acknowledged their personal key in a couple of ways:
user_session[:need_personal_key_confirmation] == true, we know they have not acknowledged their personal keyidv_session.personal_keyis blank, then they probably acknowledged their personal keyThis PR:
acknowledge_personal_key!method toidv_sessionpersonal_key_acknowledgedflag toidv_session(The ultimate goal will be to unify the tracking of personal key acknowledgement in
idv_session, but there are 50/50 deployment considerations that mean this PR needs to go out first.)