Tweaks to GPO expiration job + rake task#9590
Merged
Conversation
- Make the rake task invoke the job's .perform method directly - Note earliest + latest timestamps found in rake task output - Add configurable statement timeout to job [skip changelog]
matthinz
changed the title
(Fix brakeman warning)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I ran into some issues with Postgres statement timeouts when attempting to run the GPO expiration rake task I wrote in #9545. So I took the opportunity to clean up a few things, including:
.performmethod directly rather than duplicating the loop that the job runs in the rake task itself