Merged
Conversation
dawei-nava
force-pushed
the
dwang/LG-11260-not-ready-cancel
branch
from
ad4e244 to
f193e8b
Compare
…reference). changelog: User-Facing Improvements, Doc Auth, Return to account home.
dawei-nava
force-pushed
the
dwang/LG-11260-not-ready-cancel
branch
from
f193e8b to
24597db
Compare
amirbey
reviewed
Nov 13, 2023
Contributor
There was a problem hiding this comment.
@dawei-nava - this works as expected in accord with the testing plan ... can we add tests to check the behavior for SP vs no SP?
Contributor
Author
@amirbey , those tests are already implemented in document-capture-not-ready-spec.tsx |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
LG-11260: Fix account url, language preference.
🛠 Summary of changes
Not ready section cancel link should keep language preference.
📜 Testing Plan
Provide a checklist of steps to confirm the changes.