Skip to content

LG-11343: removes a no longer needed alert banner #9571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
solipet merged 2 commits into from
Nov 9, 2023
Merged

LG-11343: removes a no longer needed alert banner #9571

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
84f87e9
LG-11343: removes the alert banner telling users the one-time code is
solipet Nov 9, 2023
4b022a7
remove negative spec
solipet Nov 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions app/views/idv/by_mail/enter_code/index.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,10 +25,6 @@
<% end %>
<% end %>

<%= render AlertComponent.new(type: :warning, class: 'margin-bottom-3') do %>
<%= t('idv.gpo.change_to_verification_code_html') %>
<% end %>

<%= render AlertComponent.new(type: :info, class: 'margin-bottom-4', text_tag: 'div') do %>
<p>
<%= t('idv.gpo.alert_info') %>
Expand Down
2 changes: 0 additions & 2 deletions config/locales/idv/en.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,8 +180,6 @@ en:
alert_info: 'We sent a letter with your verification code to:'
alert_rate_limit_warning_html: You can’t request more letters right now. Your
previous letter request was on <strong>%{date_letter_was_sent}</strong>.
change_to_verification_code_html: 'The <strong>one-time code</strong> from your
letter is now referred to as <strong>verification code</strong>.'
clear_and_start_over: Clear your information and start over
did_not_receive_letter:
form:
Expand Down
2 changes: 0 additions & 2 deletions config/locales/idv/es.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,8 +190,6 @@ es:
alert_rate_limit_warning_html: No puede solicitar más cartas ahora mismo. Su
solicitud de carta anterior la hizo el
<strong>%{date_letter_was_sent}</strong>.
change_to_verification_code_html: 'El <strong>código único</strong> de su carta
ahora se conoce como <strong>código de verificación</strong>.'
clear_and_start_over: Borrar su información y empezar de nuevo
did_not_receive_letter:
form:
Expand Down
3 changes: 0 additions & 3 deletions config/locales/idv/fr.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,9 +195,6 @@ fr:
alert_rate_limit_warning_html: Vous ne pouvez pas demander d’autres lettres pour
le moment. Votre précédente demande de lettre a été effectuée le
<strong>%{date_letter_was_sent}</strong>.
change_to_verification_code_html: 'Le <strong>code à usage unique</strong>
figurant dans votre lettre est désormais appelé <strong>code de
vérification</strong>.'
clear_and_start_over: Supprimez vos données et recommencez
did_not_receive_letter:
form:
Expand Down
1 change: 0 additions & 1 deletion spec/features/idv/steps/enter_code_step_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,6 @@

expect(current_path).to eq idv_verify_by_mail_enter_code_path
expect(page).to have_content t('idv.gpo.alert_info')
expect(page).to have_content strip_tags(t('idv.gpo.change_to_verification_code_html'))
expect(page).to have_content t('idv.gpo.wrong_address')
expect(page).to have_content Idp::Constants::MOCK_IDV_APPLICANT_WITH_PHONE[:address1]
verify_no_rate_limit_banner
Expand Down