Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/views/idv/in_person/verify_info/show.html.erb
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,7 @@ locals:
poll_interval_ms: IdentityConfig.store.poll_rate_for_verify_in_seconds * 1000,
},
},
).with_content(t('forms.buttons.continue')) %>
).with_content(t('forms.buttons.submit.default')) %>
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ticket doesn't say to change the In person verify info submit button as far as I saw. Did we decide to keep just the buttons in sync?

</div>
</div>

Expand Down
7 changes: 6 additions & 1 deletion app/views/idv/verify_info/show.html.erb
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,11 @@ locals:
<% title t('titles.idv.verify_info') %>

<%= render PageHeadingComponent.new.with_content(t('headings.verify')) %>

<p>
<%= t('idv.messages.verify_info') %>
</p>

<div class='margin-top-4 margin-bottom-2'>
<div class="grid-row grid-gap grid-gap-2 padding-bottom-1">
<dl class="grid-col-fill margin-y-0">
Expand Down Expand Up @@ -131,7 +136,7 @@ locals:
poll_interval_ms: IdentityConfig.store.poll_rate_for_verify_in_seconds * 1000,
},
},
).with_content(t('forms.buttons.continue')) %>
).with_content(t('forms.buttons.submit.default')) %>
</div>
</div>

Expand Down
2 changes: 2 additions & 0 deletions config/locales/idv/en.yml
Original file line number Diff line number Diff line change
Expand Up @@ -286,6 +286,8 @@ en:
it.
no_pii: TEST SITE - Do not use real personal information (demo purposes only) -
TEST SITE
verify_info: We read your information from your ID. Review it and make any
updates before submitting for verification.
verifying: Verifying…
titles:
activated: Your identity has already been verified
Expand Down
2 changes: 2 additions & 0 deletions config/locales/idv/es.yml
Original file line number Diff line number Diff line change
Expand Up @@ -304,6 +304,8 @@ es:
ellos.
no_pii: SITIO DE PRUEBA - No utilice información personal real (sólo para
propósitos de demostración) - SITIO DE PRUEBA
verify_info: Leímos sus datos en su identificación. Revíselos y modifíquelos si
es necesario antes de enviarlos para la verificación.
verifying: Verificando…
titles:
activated: Ya se verificó tu identidad.
Expand Down
3 changes: 3 additions & 0 deletions config/locales/idv/fr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -314,6 +314,9 @@ fr:
y accéder.
no_pii: SITE DE TEST - N’utilisez pas de véritables données personnelles (il
s’agit d’une démonstration seulement) - SITE DE TEST
verify_info: Nous lisons vos informations à partir de votre pièce d’identité.
Passez-les en revue et mettez-les à jour avant de les soumettre pour
vérification.
verifying: Vérification…
titles:
activated: Votre identité a déjà été vérifiée
Expand Down
4 changes: 2 additions & 2 deletions spec/features/idv/doc_auth/redo_document_capture_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@

visit idv_verify_info_url

click_idv_continue
complete_verify_step

expect(page).to have_current_path(idv_phone_path)

Expand Down Expand Up @@ -107,7 +107,7 @@
let(:use_bad_ssn) { true }

it 'shows a troubleshooting option to allow the user to cancel and return to SP' do
click_idv_continue
complete_verify_step
expect(page).to have_link(
t('links.cancel'),
href: idv_cancel_path(step: :invalid_session),
Expand Down
42 changes: 21 additions & 21 deletions spec/features/idv/doc_auth/verify_info_step_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@
expect(page).to have_content('12345')
expect(page).to have_content('Apt 3E')

click_idv_continue
complete_verify_step

expect(fake_analytics).to have_logged_event(
'IdV: doc auth verify proofing results',
Expand Down Expand Up @@ -90,7 +90,7 @@
**fake_pii_details,
ssn: DocAuthHelper::GOOD_SSN,
)
click_idv_continue
complete_verify_step

expect(fake_analytics).to have_logged_event(
'IdV: doc auth verify proofing results',
Expand All @@ -108,7 +108,7 @@
)
fill_out_ssn_form_with_ssn_that_fails_resolution
click_idv_continue
click_idv_continue
complete_verify_step

expect(page).to have_current_path(idv_session_errors_warning_path)
expect_step_indicator_current_step(t('step_indicator.flows.idv.verify_info'))
Expand All @@ -127,7 +127,7 @@
fill_out_ssn_form_with_ssn_that_raises_exception

click_idv_continue
click_idv_continue
complete_verify_step

expect(fake_analytics).to have_logged_event(
'IdV: doc auth exception visited',
Expand Down Expand Up @@ -157,13 +157,13 @@
with({ limiter_context: 'single-session' })

(max_resolution_attempts - 2).times do
click_idv_continue
complete_verify_step
expect(page).to have_current_path(idv_session_errors_warning_path)
click_try_again
end

# Check that last attempt shows correct warning text
click_idv_continue
complete_verify_step
expect(page).to have_current_path(idv_session_errors_warning_path)
expect(page).to have_content(
strip_tags(
Expand All @@ -172,7 +172,7 @@
)
click_try_again

click_idv_continue
complete_verify_step
expect(page).to have_current_path(idv_session_errors_failure_path)
expect(page).not_to have_css('.step-indicator__step--current', text: text, wait: 5)
expect(fake_analytics).to have_logged_event(
Expand All @@ -187,7 +187,7 @@
travel_to(IdentityConfig.store.idv_attempt_window_in_hours.hours.from_now + 1) do
sign_in_and_2fa_user(user)
complete_doc_auth_steps_before_verify_step
click_idv_continue
complete_verify_step

expect(page).to have_current_path(idv_phone_path)
expect(RateLimiter.new(user: user, rate_limit_type: :idv_resolution)).to be_limited
Expand Down Expand Up @@ -215,7 +215,7 @@
fill_out_ssn_form_with_ssn_that_fails_resolution
click_idv_continue
(max_ssn_attempts - 1).times do
click_idv_continue
complete_verify_step
expect(page).to have_current_path(idv_session_errors_warning_path)
click_try_again
end
Expand All @@ -224,7 +224,7 @@
it 'rate limits ssn and continues when it expires' do
expect(fake_attempts_tracker).to receive(:idv_verification_rate_limited).at_least(1).times.
with({ limiter_context: 'multi-session' })
click_idv_continue
complete_verify_step
expect(page).to have_current_path(idv_session_errors_ssn_failure_path)
expect(fake_analytics).to have_logged_event(
'Rate Limit Reached',
Expand All @@ -238,7 +238,7 @@
travel_to(IdentityConfig.store.idv_attempt_window_in_hours.hours.from_now + 1) do
sign_in_and_2fa_user(user)
complete_doc_auth_steps_before_verify_step
click_idv_continue
complete_verify_step

expect(page).to have_current_path(idv_phone_path)
end
Expand All @@ -256,7 +256,7 @@

fill_in t('idv.form.ssn_label'), with: '900456789'
click_button t('forms.buttons.submit.update')
click_idv_continue
complete_verify_step

expect(page).to have_current_path(idv_phone_path)
expect(fake_analytics).not_to have_logged_event(
Expand Down Expand Up @@ -297,7 +297,7 @@

sign_in_and_2fa_user(user)
complete_doc_auth_steps_before_verify_step
click_idv_continue
complete_verify_step

expect(DocAuthLog.find_by(user_id: user.id).aamva).not_to be_nil
end
Expand All @@ -321,7 +321,7 @@

sign_in_and_2fa_user(user)
complete_doc_auth_steps_before_verify_step
click_idv_continue
complete_verify_step

expect(DocAuthLog.find_by(user_id: user.id).aamva).to be_nil
end
Expand All @@ -344,7 +344,7 @@
visit_idp_from_sp_with_ial1(:oidc)
sign_in_and_2fa_user(user)
complete_doc_auth_steps_before_verify_step
click_idv_continue
complete_verify_step

expect(DocAuthLog.find_by(user_id: user.id).aamva).to be_nil
end
Expand All @@ -359,12 +359,12 @@
allow(DocumentCaptureSession).to receive(:find_by).
and_return(nil)

click_idv_continue
complete_verify_step
expect(fake_analytics).to have_logged_event('IdV: proofing resolution result missing')
expect(page).to have_content(t('idv.failure.timeout'))
expect(page).to have_current_path(idv_verify_info_path)
allow(DocumentCaptureSession).to receive(:find_by).and_call_original
click_idv_continue
complete_verify_step
expect(page).to have_current_path(idv_phone_path)
end

Expand All @@ -381,7 +381,7 @@
allow(DocumentCaptureSession).to receive(:find_by).
and_return(nil)

click_idv_continue
complete_verify_step
expect(page).to have_content(t('idv.failure.timeout'))
expect(page).to have_current_path(idv_verify_info_path)
allow(DocumentCaptureSession).to receive(:find_by).and_call_original
Expand All @@ -396,11 +396,11 @@
allow(DocumentCaptureSession).to receive(:find_by).
and_return(nil)

click_idv_continue
complete_verify_step
expect(page).to have_content(t('idv.failure.timeout'))
expect(page).to have_current_path(idv_verify_info_path)
allow(DocumentCaptureSession).to receive(:find_by).and_call_original
click_idv_continue
complete_verify_step
expect(page).to have_current_path(idv_phone_path)
end
end
Expand All @@ -418,7 +418,7 @@
end

it 'redirects to the gpo page when continuing from verify info page' do
click_idv_continue
complete_verify_step
expect(page).to have_current_path(idv_request_letter_path)

click_on 'Cancel'
Expand Down
8 changes: 4 additions & 4 deletions spec/features/idv/hybrid_mobile/hybrid_mobile_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@
click_idv_continue

expect(page).to have_content(t('headings.verify'))
click_idv_continue
complete_verify_step

prefilled_phone = page.find(id: 'idv_phone_form_phone').value

Expand Down Expand Up @@ -252,7 +252,7 @@
expect(page).to have_text(Idp::Constants::MOCK_IDV_APPLICANT[:last_name])
expect(page).to have_text(Idp::Constants::MOCK_IDV_APPLICANT[:address1])

click_idv_continue
complete_verify_step
end
end
end
Expand Down Expand Up @@ -308,7 +308,7 @@
expect(page).to have_text(Idp::Constants::MOCK_IDV_APPLICANT[:last_name])
expect(page).to have_text(Idp::Constants::MOCK_IDV_APPLICANT[:address1])

click_idv_continue
complete_verify_step
end
end
end
Expand Down Expand Up @@ -342,7 +342,7 @@
click_idv_continue

expect(page).to have_content(t('headings.verify'))
click_idv_continue
complete_verify_step

prefilled_phone = page.find(id: 'idv_phone_form_phone').value

Expand Down
4 changes: 2 additions & 2 deletions spec/features/idv/steps/in_person/verify_info_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@
complete_state_id_step(user)
fill_out_ssn_form_with_ssn_that_fails_resolution
click_idv_continue
click_idv_continue
complete_verify_step(user)

expect(page).to have_current_path(idv_session_errors_warning_path(flow: 'in_person'))
click_on t('idv.failure.button.warning')
Expand All @@ -161,7 +161,7 @@
complete_location_step(user)
complete_state_id_step(user)
complete_ssn_step(user)
click_idv_continue
complete_verify_step(user)

expect(page).to have_content(t('titles.idv.phone'))
expect(fake_analytics).to have_logged_event(
Expand Down
4 changes: 2 additions & 2 deletions spec/features/idv/threat_metrix_pending_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
complete_doc_auth_steps_before_ssn_step
select 'Reject', from: :mock_profiling_result
complete_ssn_step
click_idv_continue
complete_verify_step
complete_phone_step(user)
complete_enter_password_step(user)
acknowledge_and_confirm_personal_key
Expand Down Expand Up @@ -117,7 +117,7 @@
complete_doc_auth_steps_before_ssn_step
select 'No Result', from: :mock_profiling_result
complete_ssn_step
click_idv_continue
complete_verify_step

expect(page).to have_content(t('idv.failure.sessions.exception'))
expect(page).to have_current_path(idv_session_errors_exception_path)
Expand Down
4 changes: 2 additions & 2 deletions spec/support/features/doc_auth_helper.rb
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@ def complete_doc_auth_steps_before_verify_step(expect_accessible: false)
end

def complete_verify_step
click_idv_continue
click_idv_submit_default
end

def complete_doc_auth_steps_before_address_step(expect_accessible: false)
Expand Down Expand Up @@ -315,7 +315,7 @@ def complete_all_idv_steps_with(threatmetrix:)
complete_doc_auth_steps_before_ssn_step
select threatmetrix, from: :mock_profiling_result
complete_ssn_step
click_idv_continue
complete_verify_step
complete_phone_step(user)
complete_enter_password_step(user)
acknowledge_and_confirm_personal_key
Expand Down
4 changes: 4 additions & 0 deletions spec/support/features/idv_helper.rb
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,10 @@ def click_idv_continue
click_spinner_button_and_wait t('forms.buttons.continue')
end

def click_idv_submit_default
click_spinner_button_and_wait t('forms.buttons.submit.default')
end

def click_idv_update
click_on t('forms.buttons.submit.update')
end
Expand Down
2 changes: 1 addition & 1 deletion spec/support/features/in_person_helper.rb
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@ def complete_ssn_step(_user = nil)
end

def complete_verify_step(_user = nil)
click_idv_continue
click_idv_submit_default
end

def complete_all_in_person_proofing_steps(user = user_with_2fa, same_address_as_id: true)
Expand Down