Skip to content

Update Account Deletion Rate to match data.login.gov#9516

Merged
zachmargolis merged 3 commits intomainfrom
margolis-monthly-reporting-account-deletion
Nov 1, 2023
Merged

Update Account Deletion Rate to match data.login.gov#9516
zachmargolis merged 3 commits intomainfrom
margolis-monthly-reporting-account-deletion

Conversation

@zachmargolis
Copy link
Contributor

@zachmargolis zachmargolis commented Nov 1, 2023

🛠 Summary of changes

Updates the emailed Monthly Key Metrics report to use the same "deletion rate" math as data.login.gov

- Uses 'fully registered' users
- Matches timestamp logic

changelog: Internal, Reporting, Update monthly key metrics report
@zachmargolis zachmargolis requested review from a team November 1, 2023 19:49
Comment on lines 43 to 45
def deletion_rate
deleted_user_count.to_f / users_and_deleted_for_period.to_f
deleted_user_count.to_f / fully_registered_users.to_f
end
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One thing to note, I'm not 100% sure I agree with the calculation on data.login.gov, because "fully registered users" is not safe for backdating, the registrations logs rows are deleted and not recoverable, where the "total registered" is, we can approximate counts far back in time based on deleted_users

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For what it's worth, I'm not attached to that logic (as the person who wrote it), if we want to update to something more accurate and backport to data.login.gov .

But also we're tentatively considering to want to change this to an "Account Reset Rate" anyways, so maybe it's best to hold off for that.

Copy link
Contributor

@aduth aduth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment on lines 43 to 45
def deletion_rate
deleted_user_count.to_f / users_and_deleted_for_period.to_f
deleted_user_count.to_f / fully_registered_users.to_f
end
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For what it's worth, I'm not attached to that logic (as the person who wrote it), if we want to update to something more accurate and backport to data.login.gov .

But also we're tentatively considering to want to change this to an "Account Reset Rate" anyways, so maybe it's best to hold off for that.

@zachmargolis zachmargolis merged commit 24abb7f into main Nov 1, 2023
@zachmargolis zachmargolis deleted the margolis-monthly-reporting-account-deletion branch November 1, 2023 22:24
@amirbey amirbey mentioned this pull request Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants