Merged
Conversation
added 3 commits
November 1, 2023 12:49
changelog: Internal, Dependencies, Update Rubocop and rules
mitchellhenke
commented
Nov 1, 2023
| Performance/StringIdentifierArgument: | ||
| Enabled: true | ||
|
|
||
| Performance/StringInclude: |
Contributor
Author
There was a problem hiding this comment.
Most of the changes are due to this rule. It is not strictly backwards compatible since symbols and nil would work for the old format of %r{/pattern/}.match?(nil) or %r{/pattern/}.match?(:pattern). It didn't look like our usages would break due to this though (and we probably want to skip the match anyway in the nil case).
zachmargolis
approved these changes
Nov 1, 2023
Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
This PR updates rubocop-performance and enables some of the newer rules based on recommendations in standardrb.