Skip to content

Fix bug with missing require in email-deliveries script#9507

Merged
mitchellhenke merged 1 commit intomainfrom
mitchellhenke/require-object-blank-for-email-delivieries
Nov 1, 2023
Merged

Fix bug with missing require in email-deliveries script#9507
mitchellhenke merged 1 commit intomainfrom
mitchellhenke/require-object-blank-for-email-delivieries

Conversation

@mitchellhenke
Copy link
Contributor

🛠 Summary of changes

The script makes use of #present? and fails without the require:

/Users/mitchellehenke/projects/identity-idp/lib/reporting/cloudwatch_client.rb:231:in `slice_time_range': undefined method `present?' for nil:NilClass (NoMethodError)

      if time_slices.present?
                    ^^^^^^^^^
        from /Users/mitchellehenke/projects/identity-idp/lib/reporting/cloudwatch_client.rb:64:in `fetch'
        from bin/oncall/email-deliveries:91:in `block in query_data'
        from /Users/mitchellehenke/projects/identity-idp/lib/reporting/unknown_progress_bar.rb:24:in `wrap'
        from bin/oncall/email-deliveries:90:in `query_data'
        from bin/oncall/email-deliveries:60:in `run'
        from bin/oncall/email-deliveries:150:in `<main>'

changelog: Internal, Scripts, Fix bug with missing require in email-deliveries script
Copy link
Contributor

@zachmargolis zachmargolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! LGTM

@mitchellhenke mitchellhenke merged commit bee5010 into main Nov 1, 2023
@mitchellhenke mitchellhenke deleted the mitchellhenke/require-object-blank-for-email-delivieries branch November 1, 2023 15:34
@amirbey amirbey mentioned this pull request Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants