Skip to content

Update devise to fix deprecation warning#9496

Merged
mitchellhenke merged 1 commit intomainfrom
mitchellhenke/update-devise
Oct 31, 2023
Merged

Update devise to fix deprecation warning#9496
mitchellhenke merged 1 commit intomainfrom
mitchellhenke/update-devise

Conversation

@mitchellhenke
Copy link
Contributor

🛠 Summary of changes

The changes in #9357 included some deprecations that I missed. Example:

DEPRECATION WARNING: DeprecatedConstantAccessor.deprecate_constant without a deprecator is deprecated (called from <top (required)> at /Users/andrewmduthie/Documents/Code/identity-idp/config/application.rb:20)
Run options: include {:locations=>{"./spec/features/two_factor_authentication/sign_in_spec.rb"=>[62]}}

The deprecation comes from devise and was fixed in heartcombo/devise#5599. Updating devise removes the warning.

changelog: Internal, Dependencies, Update devise to fix deprecation warning
@mitchellhenke mitchellhenke requested a review from aduth October 31, 2023 19:39
@mitchellhenke mitchellhenke merged commit 9373d2b into main Oct 31, 2023
@mitchellhenke mitchellhenke deleted the mitchellhenke/update-devise branch October 31, 2023 20:33
@amirbey amirbey mentioned this pull request Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants