LG-11023 Unpublish old come_back_later URL and republish old enter_code URL#9486
Merged
LG-11023 Unpublish old come_back_later URL and republish old enter_code URL#9486
Conversation
jmhooper
force-pushed
the
jmhooper-retire-routes
branch
from
659403f to
a8ab073
Compare
…de URL We made changes to the routes for the verify by mail code entry and come back later URLs. The come_back_later URL has a reasonably low amount of traffic to it. This commit unpublishes it for that reason. The enter_code URL does have traffic to it. Currently it redirects which strips a query param included in the URL. To support that query param this commit republishes it so that query parameter works. changelog: Internal, URLs, The /verify/come_back_later url was unpubished and the /verify/by_mail URL was republished
jmhooper
force-pushed
the
jmhooper-retire-routes
branch
from
a8ab073 to
103c1a9
Compare
soniaconnolly
approved these changes
Oct 31, 2023
Contributor
soniaconnolly
left a comment
soniaconnolly
left a comment
There was a problem hiding this comment.
LGTM. I checked current source and it looks like we updated the email to send out the correct URL going forward.
matthinz
approved these changes
Nov 1, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We made changes to the routes for the verify by mail code entry and come back later URLs.
The come_back_later URL has a reasonably low amount of traffic to it. This commit unpublishes it for that reason.
The enter_code URL does have traffic to it. Currently it redirects which strips a query param included in the URL. To support that query param this commit republishes it so that query parameter works.