LG-11278: Group authentication app setup fields with fieldset

[aduth]

🎫 Ticket

LG-11278

🛠 Summary of changes

Adds a fieldset grouping to the TOTP setup screen, to logically group related fields.

Related resource: https://www.w3.org/TR/WCAG20-TECHS/H71.html

This is a non-visual change, as it labels the fieldset using aria-labeledby with an existing text on the page "Set up an authentication app to sign in using temporary security codes.".

Recommended to review with whitespace changes hidden due to most view changes being the addition of a wrapping element that increases the tab level of most content.

📜 Testing Plan

You can inspect the grouping element with your browser DevTool's "Accessibility" inspector to confirm the named grouping:

You can also confirm with a screen reader that entering the form fields announces the group

👀 Screenshots

There are no visual changes, but here is the screen for reference:

[aduth]

Could / should probably move this elsewhere and add tests for it? Unclear if that makes sense and where would be best for a utility only used in specs.

[jmdembe]

I think this is fine here. How would this differ from the rest of the file?

[aduth]

My main concern is if we'd want to have a convention of one-class-per-file, and files containing a class only containing that class. It'd also be nice to have some test coverage for it, but we don't typically enforce test coverage for test helpers.

[kevinsmaster5]

You could break it out as accessibility_be_logically_grouped.rb or something like that.
I wonder if the other classes in that test helper should be split off also?

[aduth]

I think I'll keep this as-is for now, but I do like the idea of maybe creating a new folder within helpers for accessibility helpers, which would be more scalable and let us do one-class/matcher-per-file.

[kevinsmaster5]

solution looks good and validated locally.