Skip to content

Remove "transitional" compatibility from changelog script #9479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aduth merged 1 commit into from
Oct 30, 2023
Merged

Remove "transitional" compatibility from changelog script #9479

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions scripts/changelog_check.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
%r{^(?:\* )?changelog: ?(?<category>[\w -]{2,}), ?(?<subcategory>[\w -]{2,}), ?(?<change>.+)$}i
CATEGORIES = [
'User-Facing Improvements',
'Improvements', # Temporary for transitional period
'Bug Fixes',
'Internal',
'Upcoming Features',
Expand Down Expand Up @@ -106,7 +105,7 @@ def generate_invalid_changes(git_log)
end

def closest_change_category(change)
category = CATEGORIES.
CATEGORIES.
map do |category|
CategoryDistance.new(
category,
Expand All @@ -116,10 +115,6 @@ def closest_change_category(change)
filter { |category_distance| category_distance.distance <= MAX_CATEGORY_DISTANCE }.
max { |category_distance| category_distance.distance }&.
category

# Temporarily normalize legacy category in transitional period
category = 'User-Facing Improvements' if category == 'Improvements'
category
end

# Get the last valid changelog line for every Pull Request and tie it to the commit subject.
Expand Down