Skip to content

Don't redirect to PhoneQuestion from HybridHandoff if referer is nil #9472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
soniaconnolly wants to merge 1 commit into from
Closed

Don't redirect to PhoneQuestion from HybridHandoff if referer is nil #9472

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions app/controllers/concerns/idv/phone_question_ab_test_concern.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ def phone_question_user

def maybe_redirect_for_phone_question_ab_test
return if phone_question_ab_test_bucket != :show_phone_question
return if request.referer.blank? # avoid redirect loop
return if request.referer == idv_phone_question_url
return if request.referer == idv_link_sent_url
return if request.referer == idv_hybrid_handoff_url
Expand Down
5 changes: 5 additions & 0 deletions spec/features/idv/doc_auth/hybrid_handoff_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,6 +201,11 @@
expect(page).to have_current_path(idv_phone_question_path)
click_link t('doc_auth.buttons.have_phone')

# added to test FlowPolicy behavior with PhoneQuestion
expect(page).to have_current_path(idv_hybrid_handoff_path)
visit(idv_link_sent_url)
expect(page).to have_current_path(idv_hybrid_handoff_path)

freeze_time do
idv_send_link_max_attempts.times do
expect(page).to_not have_content(
Expand Down