You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I don't think we'll want to remove the skip link, since even if a screen reader user could navigate the page using existing landmarks, it's still useful for both (a) screen reader users who don't use landmarks to navigate a page, and (b) keyboard users.
We have a similar ticket in our team's backlog (LG-11274) and I wrote a comment summarizing why I don't think this is an issue:
Conversely, including a skip link inside a landmark may provide a worse experience, since if someone uses landmarks to navigate the page, it's unlikely they would be interested in navigating to the portion of the page including the skip link. At best, this would be redundant, and at worst misleading.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
Link to the relevant ticket.
🛠 Summary of changes
Remove 'Skip to main content' link from base layout.
📜 Testing Plan
Run the test suite.