LG-11101: Double-track auth methods session value (Part 1 of 2)#9388
Merged
LG-11101: Double-track auth methods session value (Part 1 of 2)#9388
Conversation
spec/controllers/two_factor_authentication/otp_verification_controller_spec.rb
Outdated
Show resolved
Hide resolved
jmdembe
approved these changes
Oct 16, 2023
[skip changelog]
See: #9388 (comment) Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
See: #9388 (comment) Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
aduth
force-pushed
the
aduth-lg-11101-auth-events-double-track
branch
from
3a09842 to
789cf0c
Compare
mitchellhenke
approved these changes
Oct 16, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
LG-11101
🛠 Summary of changes
Starts double-tracking authentication events to a new session value, in preparation for #9335 (Part 2) to switch over to that session value for considering whether one of the events would satisfy an authentication request.
📜 Testing Plan
Since this is only setting but not reading from a new session value, there should not be an expected change in user behavior.
Verify there are no regressions in allowing the user to be considered authenticated, e.g. by remember device cookie, or AAL2 strict requests. See testing plan in #9335 for example.