LG-10849 Use hybrid flow phone number in phone form#9379
Merged
Conversation
amirbey
reviewed
Oct 13, 2023
Comment on lines
339
to
353
Contributor
There was a problem hiding this comment.
could be worth inserting this same check (using MFA # 202-555-1212) on line 83 above 🤔
amirbey
approved these changes
Oct 13, 2023
Contributor
amirbey
left a comment
amirbey
left a comment
There was a problem hiding this comment.
LGTM ... made 1 suggestion to consider testing MFA prefilled on phone step 👍🏿
This commit uses the phone number a user used to complete the hybrid flow if we have the user has no MFA phone number. Hopefully pre-filling the number in this way will help improve success on the phone step. changelog: User-Facing Improvements, IdV Phone Step, The hybrid flow phone is pre-filled on the phone step if the user has no MFA phone number to pre-fill.
jmhooper
force-pushed
the
jmhooper-hybrid-handoff-phone
branch
from
fb4952d to
210a9b6
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit uses the phone number a user used to complete the hybrid flow if we have the user has no MFA phone number. Hopefully pre-filling the number in this way will help improve success on the phone step.