Skip to content

Lg 11183 document upload proofing automate#9372

Merged
ThatSpaceGuy merged 7 commits intomainfrom
LG-11183-Document-Upload-Proofing-Automate
Oct 13, 2023
Merged

Lg 11183 document upload proofing automate#9372
ThatSpaceGuy merged 7 commits intomainfrom
LG-11183-Document-Upload-Proofing-Automate

Conversation

@ThatSpaceGuy
Copy link
Contributor

@ThatSpaceGuy ThatSpaceGuy requested a review from a team October 12, 2023 17:56
Copy link
Contributor

@n1zyy n1zyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good, but I wonder if it's possible to separate the other changes (rearranging existing code) into a separate PR?

@ThatSpaceGuy ThatSpaceGuy force-pushed the LG-11183-Document-Upload-Proofing-Automate branch from 4775461 to c5a0a17 Compare October 12, 2023 18:58
@ThatSpaceGuy ThatSpaceGuy force-pushed the LG-11183-Document-Upload-Proofing-Automate branch from 1428b42 to e9210dd Compare October 13, 2023 03:07
Copy link
Contributor

@zachmargolis zachmargolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
@ThatSpaceGuy ThatSpaceGuy merged commit 7d95229 into main Oct 13, 2023
@ThatSpaceGuy ThatSpaceGuy deleted the LG-11183-Document-Upload-Proofing-Automate branch October 13, 2023 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants