Conversation
changelog: Internal, Dependencies, Update dependencies to latest versions
| import { Readable } from 'node:stream'; | ||
| import { pipeline } from 'node:stream/promises'; | ||
| import sass from 'sass-embedded'; | ||
| import { compile as sassCompile } from 'sass-embedded'; |
There was a problem hiding this comment.
This change was to address a deprecation which was causing some output from the build command:
`import sass from 'sass'` is deprecated.
Please use `import * as sass from 'sass'` instead.
There was a problem hiding this comment.
The rename from compile to sassCompile is just for readability, not a collision, right?
There was a problem hiding this comment.
The rename from
compiletosassCompileis just for readability, not a collision, right?
Correct, since we use a couple different processing tools (Sass, LightningCSS), I wanted to avoid potential ambiguity of what "compile" refers to, and follow the convention I'd introduced on the following line of with lightningTransform ➡️ toolOperation ➡️ sassCompile.
| import { Readable } from 'node:stream'; | ||
| import { pipeline } from 'node:stream/promises'; | ||
| import sass from 'sass-embedded'; | ||
| import { compile as sassCompile } from 'sass-embedded'; |
There was a problem hiding this comment.
The rename from compile to sassCompile is just for readability, not a collision, right?
|
Published to NPM as https://www.npmjs.com/package/@18f/identity-build-sass?activeTab=versions |
2 participants
🛠 Summary of changes
Updates dependencies of
@18f/identity-build-sassto latest versions.Why?
sass-embeddedin local development and in deployed instances (see Slack discussion)📜 Testing Plan
Verify stylesheets build successfully:
yarn build:cssVerify no visual regressions in the application
make run