LG-11221 Personal key doesn't change on page refresh#9363
Merged
soniaconnolly merged 3 commits intomainfrom Oct 12, 2023
Merged
LG-11221 Personal key doesn't change on page refresh#9363soniaconnolly merged 3 commits intomainfrom
soniaconnolly merged 3 commits intomainfrom
Conversation
changelog: Bug Fixes, Identity Verification Personal Key, show same Personal Key when page is refreshed
aduth
reviewed
Oct 11, 2023
jmhooper
approved these changes
Oct 12, 2023
jmhooper
reviewed
Oct 12, 2023
| code = subject.idv_session.personal_key | ||
|
|
||
| get :show | ||
| get :show |
Contributor
There was a problem hiding this comment.
Nice, I would have had to write an expensive feature test for this.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
LG-11221
🛠 Summary of changes
Previously, when the user refreshed the Personal Key page, a new key was generated each time. This could prevent the user from recovering their account if they saved the previous key and didn't notice it had changed. Now, the personal key remains the same when the page is refreshed.
📜 Testing Plan