Don't run MonthlyKeyMetricsReport if there are no recipients#9362
Merged
Don't run MonthlyKeyMetricsReport if there are no recipients#9362
Conversation
[skip changelog]
zachmargolis
approved these changes
Oct 11, 2023
Contributor
zachmargolis
left a comment
zachmargolis
left a comment
There was a problem hiding this comment.
I don't think we strictly need this but the code LGTM
ThatSpaceGuy
approved these changes
Oct 12, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check if there are any recipients for the email report, and bail out before generating the report if there are none. This should save dozens of CPU cycles.
Note: This will also mean we don't do the upload to S3. I am operating on the assumption that if there are no email recipients, it's in an environment where we don't care about the report and thus don't need to upload it to S3 or run it at all. We should reject this PR if that's not true.
🎫 Ticket
None; can be linked to my work on LG-10812 if needed.