Skip to content

Update changelog script to reflect non-security Dependabot usage #9354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aduth merged 1 commit into from
Oct 11, 2023
Merged

Update changelog script to reflect non-security Dependabot usage #9354

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion scripts/changelog_check.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
SECURITY_CHANGELOG = {
category: 'Internal',
subcategory: 'Dependencies',
change: 'Update dependencies to resolve security advisories',
change: 'Update dependencies to latest versions',
}.freeze
REVERT_CHANGELOG = {
category: 'Bug Fixes',
Expand Down
15 changes: 15 additions & 0 deletions spec/fixtures/git_log_changelog.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,3 +130,18 @@ commit_changelog_with_commas_in_change:
pr_number: '7000'
commit_messages:
- 'changelog:Internal,Changelog,Allow listing one, two, and more items with commas'
dependabot_dependency_update:
commit_log: |
title: Bump libphonenumber-js from 1.10.46 to 1.10.47 (#9332)
body:...

Signed-off-by: dependabot[bot] <support@github.com>
DELIMITER
title: Bump libphonenumber-js from 1.10.46 to 1.10.47 (#9332)
category: Internal
subcategory: Dependencies
change: Update dependencies to latest versions
pr_number: '9332'
commit_messages:
- '...'
- 'Signed-off-by: dependabot[bot] <support@github.com>'
2 changes: 1 addition & 1 deletion spec/scripts/changelog_check_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
it 'builds a git log into structured changelog objects' do
git_log = git_fixtures.values.pluck('commit_log').join("\n")
changelog_entries = generate_changelog(git_log)
expect(changelog_entries.length).to eq 8
expect(changelog_entries.length).to eq 9
fixture_and_changelog = git_fixtures.values.filter do |x|
x['category'].present?
end.zip(changelog_entries)
Expand Down