Remove unused ServiceProviderMfaPolicy from GenericDeliveryPresenter#9334
Merged
Remove unused ServiceProviderMfaPolicy from GenericDeliveryPresenter#9334
Conversation
changelog: Internal, Code Quality, Remove unreachable code
mitchellhenke
approved these changes
Oct 6, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
Relates to / simplifies LG-11101
🛠 Summary of changes
Removes references to
ServiceProviderMfaPolicyinGenericDeliveryPresenterwhich appear to be unused.Previous usage:
WebauthnAuthenticationPresenter#multiple_factors_enabled?reference added in LG-5515: update platform auth #5976, last reference removed in LG 8622 Removes stand alone error page for F/T Unlock (only WebAuthn Method) #8716PivCacAuthenticationPresenterreferences added in Merge logic for dealing with AAL3 and PIV/CAC requirement #4014, last references removed in LG-10286: Allow AAL2-restricted sign in to choose another option #8837📜 Testing Plan