Skip to content

Update guidance for frontend error logging#9330

Merged
aduth merged 1 commit intomainfrom
aduth-frontend-error-docs
Oct 6, 2023
Merged

Update guidance for frontend error logging#9330
aduth merged 1 commit intomainfrom
aduth-frontend-error-docs

Conversation

@aduth
Copy link
Contributor

@aduth aduth commented Oct 6, 2023

🛠 Summary of changes

Updates frontend documentation for guidance on how to debug production JavaScript errors, since the previous guidance became obsolete as of #8950.

📜 Testing Plan

Review documentation for accuracy / helpfulness.

changelog: Internal, Documentation, Update guidance for frontend error logging
@aduth aduth requested a review from jmdembe October 6, 2023 14:21
Copy link
Contributor

@jmdembe jmdembe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@aduth aduth merged commit 867853e into main Oct 6, 2023
@aduth aduth deleted the aduth-frontend-error-docs branch October 6, 2023 18:15
@jmdembe jmdembe mentioned this pull request Oct 10, 2023
jmdembe added a commit that referenced this pull request Oct 10, 2023
* Fix secrets detection build step to improve branch detection (#9320)

* Empty commit

* Fetch prior to secrets analyze

* Better main detection

* s/and/&&/

* Fix "if" syntax

* Add changelog

changelog: Internal, Continuous Integration, Add secret scanning job

* Retire the ProfileMigrationJob (#9322)

The ProfileMigrationJob has migrated all of the Profile records that needed migrating so it can be removed

[skip changelog]

* Bump libphonenumber-js from 1.10.45 to 1.10.46 (#9325)

Bumps [libphonenumber-js](https://gitlab.com/catamphetamine/libphonenumber-js) from 1.10.45 to 1.10.46.
- [Changelog](https://gitlab.com/catamphetamine/libphonenumber-js/blob/master/CHANGELOG.md)
- [Commits](https://gitlab.com/catamphetamine/libphonenumber-js/compare/v1.10.45...v1.10.46)

---
updated-dependencies:
- dependency-name: libphonenumber-js
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Fix alert paragraph rendering semantics, redundant styling (#9317)

* Remove unnecessary text_tag overrides

changelog: Bug Fixes, Alerts, Fix HTML semantics for some alerts

* Remove redundant margin reset on alert paragraph

* Gitignore .bak files (#9324)

* Gitignore .bak files

Avoid accidentally checking in stray backup files.

[skip changelog]

* Ignore files with .bak extension

---------

Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov>

* Bump libphonenumber-js from 1.10.46 to 1.10.47 (#9332)

Bumps [libphonenumber-js](https://gitlab.com/catamphetamine/libphonenumber-js) from 1.10.46 to 1.10.47.
- [Changelog](https://gitlab.com/catamphetamine/libphonenumber-js/blob/master/CHANGELOG.md)
- [Commits](https://gitlab.com/catamphetamine/libphonenumber-js/compare/v1.10.46...v1.10.47)

---
updated-dependencies:
- dependency-name: libphonenumber-js
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Update guidance for frontend error logging (#9330)

changelog: Internal, Documentation, Update guidance for frontend error logging

* Rename ial2_consent_given (3/3) (#9288)

Follow on to #9287, removes all references to / support for ial2_consent_given. Should not be merged until that PR is deployed.

[skip changelog]

* Exclude certain paths from secrets detection (#9337)

There are false positives identified when running the Gitlab secret detector locally.

[skip changelog]

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov>
Co-authored-by: Jonathan Hooper <jonathan.hooper@gsa.gov>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Sonia Connolly <sonia.connolly@gsa.gov>
Co-authored-by: Matt Hinz <matt.hinz@gsa.gov>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants