Conversation
jmax-gsa
approved these changes
Oct 6, 2023
Contributor
jmax-gsa
left a comment
There was a problem hiding this comment.
LGTM. That cleaned up nicely.
aduth
approved these changes
Oct 6, 2023
Contributor
aduth
left a comment
There was a problem hiding this comment.
Not affected by the changes here, but I came across this seemingly-unused doc auth async event, should it be removed too?
identity-idp/app/services/analytics_events.rb
Lines 292 to 298 in 3ea986a
soniaconnolly
approved these changes
Oct 6, 2023
Contributor
soniaconnolly
left a comment
There was a problem hiding this comment.
LGTM. Tried both standard and hybrid flow locally, and both reflected the documents correctly at VerifyInfo
50cdfef to
3928ef9
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
LG-11012
Background
🛠 Summary of changes
Remove defunct
load_doc_auth_async_resultandDocumentCaptureSessionAsyncResult