Skip to content

LG-11012 follow up PR to remove load doc auth async result#9327

Merged
amirbey merged 7 commits intomainfrom
amirbey/LG-11012-follow-up-remove-load-doc-auth-async-result
Oct 10, 2023
Merged

LG-11012 follow up PR to remove load doc auth async result#9327
amirbey merged 7 commits intomainfrom
amirbey/LG-11012-follow-up-remove-load-doc-auth-async-result

Conversation

@amirbey
Copy link
Contributor

@amirbey amirbey commented Oct 5, 2023

🎫 Ticket

LG-11012

Background

🛠 Summary of changes

Remove defunct load_doc_auth_async_result and DocumentCaptureSessionAsyncResult

@amirbey amirbey marked this pull request as ready for review October 6, 2023 14:41
@amirbey amirbey changed the title Amirbey/lg 11012 follow up remove load doc auth async result LG-11012 follow up PR to remove load doc auth async result Oct 6, 2023
Copy link
Contributor

@jmax-gsa jmax-gsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. That cleaned up nicely.

Copy link
Contributor

@aduth aduth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not affected by the changes here, but I came across this seemingly-unused doc auth async event, should it be removed too?

# @param [String, nil] error error message
# @param [String, nil] uuid document capture session uuid
# @param [String, nil] result_id document capture session result id
# When there is an error loading async results during the document authentication flow
def doc_auth_async(error: nil, uuid: nil, result_id: nil, **extra)
track_event('Doc Auth Async', error: error, uuid: uuid, result_id: result_id, **extra)
end

Copy link
Contributor

@soniaconnolly soniaconnolly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tried both standard and hybrid flow locally, and both reflected the documents correctly at VerifyInfo

@amirbey amirbey force-pushed the amirbey/LG-11012-follow-up-remove-load-doc-auth-async-result branch from 50cdfef to 3928ef9 Compare October 10, 2023 15:59
@amirbey amirbey merged commit d971cba into main Oct 10, 2023
@amirbey amirbey deleted the amirbey/LG-11012-follow-up-remove-load-doc-auth-async-result branch October 10, 2023 16:39
@jmhooper jmhooper mentioned this pull request Oct 10, 2023
@amirbey amirbey self-assigned this Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants