Jmax/lg 9565 re enable reminder letter job#9319
Merged
Conversation
changelog: Upcoming Features, USPS verification, re-enable reminder job.
Moved `profiles_due_for_reminder` out to its own method and set up a constant for the database timeout.
Co-authored-by: Sonia Connolly <sonia.connolly@gsa.gov>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
LG-9595
🛠 Summary of changes
Fix a bug where users with multiple GPO letter requests outstanding would recieve multiple reminder emails for one of them, not the single reminder that they should. (We weren't marking all of the GPO requests as 'reminder sent' after sending a reminder, only the most recent one.)
📜 Testing Plan
Provide a checklist of steps to confirm the changes.
GpoConfirmationCode.allto find yours, thenGpoConfirmationCode.find(<your code's id>).update(created_at: 2.weeks.ago, updated_at: 2.weeks.ago, code_sent_at: 2.weeks.ago)GpoReminderJob.perform_now(2.weeks.ago))