Enable back button through document capture

app/controllers/concerns/idv_step_concern.rb

@@ -45,29 +45,31 @@ def flow_path
   end
 
   def confirm_hybrid_handoff_needed
-    setup_for_redo if params[:redo]
-
-    if idv_session.skip_hybrid_handoff?
-      # We previously skipped hybrid handoff. Keep doing that.
-      idv_session.flow_path = 'standard'
+    if params[:redo]
+      idv_session.redo_document_capture = true
+    elsif idv_session.document_capture_complete?
+      redirect_to idv_ssn_url
+      return
     end
 
-    if !FeatureManagement.idv_allow_hybrid_flow?
-      # When hybrid flow is unavailable, skip it.
-      # But don't store that we skipped it in idv_session, in case it is back to
-      # available when the user tries to redo document capture.
+    # If we previously skipped hybrid handoff, keep doing that.
+    # If hybrid flow is unavailable, skip it.
+    # But don't store that we skipped it in idv_session, in case it is back to
+    # available when the user tries to redo document capture.
+    if idv_session.skip_hybrid_handoff? || !FeatureManagement.idv_allow_hybrid_flow?
       idv_session.flow_path = 'standard'
-    end
-
-    if idv_session.flow_path == 'standard'
       redirect_to idv_document_capture_url
-    elsif idv_session.flow_path == 'hybrid'
-      redirect_to idv_link_sent_url
     end
   end
 
   private
 
+  def confirm_document_capture_not_complete
+    return unless idv_session.document_capture_complete?
+
+    redirect_to idv_ssn_url
+  end
+
   def confirm_ssn_step_complete
     return if pii.present? && idv_session.ssn.present?
     redirect_to prev_url
@@ -117,16 +119,4 @@ def extra_analytics_properties
     end
     extra
   end
-
-  def setup_for_redo
-    idv_session.redo_document_capture = true
-
-    # If we previously skipped hybrid handoff for the user (because they're on a mobile
-    # device with a camera), skip it _again_ here.
-    if idv_session.skip_hybrid_handoff?
-      idv_session.flow_path = 'standard'
-    else
-      idv_session.flow_path = nil
-    end
-  end
 end

app/controllers/idv/agreement_controller.rb

@@ -5,7 +5,7 @@ class AgreementController < ApplicationController
 
     before_action :confirm_not_rate_limited
     before_action :confirm_welcome_step_complete
-    before_action :confirm_agreement_needed
+    before_action :confirm_document_capture_not_complete
 
     def show
       analytics.idv_doc_auth_agreement_visited(**analytics_arguments)
@@ -14,6 +14,10 @@ def show
         'agreement', :view,
         true
       )
+
+      @consent_form = Idv::ConsentForm.new(
+        idv_consent_given: idv_session.idv_consent_given,
+      )
     end
 
     def update

app/controllers/idv/getting_started_controller.rb

@@ -3,7 +3,7 @@ class GettingStartedController < ApplicationController
     include IdvStepConcern
 
     before_action :confirm_not_rate_limited
-    before_action :confirm_agreement_needed
+    before_action :confirm_document_capture_not_complete
 
     def show
       analytics.idv_doc_auth_getting_started_visited(**analytics_arguments)
@@ -75,11 +75,5 @@ def skip_to_capture
     def consent_form_params
       params.require(:doc_auth).permit(:idv_consent_given)
     end
-
-    def confirm_agreement_needed
-      return unless idv_session.idv_consent_given
-
-      redirect_to idv_hybrid_handoff_url
-    end
   end
 end

app/controllers/idv/phone_question_controller.rb

@@ -31,7 +31,7 @@ def phone_without_camera
                 merge(phone_with_camera: false),
       )
 
-      redirect_to idv_hybrid_handoff_url
+      redirect_to idv_document_capture_url
     end
 
     private

app/controllers/idv/welcome_controller.rb

@@ -5,7 +5,7 @@ class WelcomeController < ApplicationController
     include GettingStartedAbTestConcern
 
     before_action :confirm_not_rate_limited
-    before_action :confirm_welcome_needed
+    before_action :confirm_document_capture_not_complete
     before_action :maybe_redirect_for_getting_started_ab_test
 
     def show
@@ -56,11 +56,5 @@ def cancel_previous_in_person_enrollments
       UspsInPersonProofing::EnrollmentHelper.
         cancel_stale_establishing_enrollments_for_user(current_user)
     end
-
-    def confirm_welcome_needed
-      return unless idv_session.welcome_visited
-
-      redirect_to idv_agreement_url
-    end
   end
 end

app/forms/idv/consent_form.rb

@@ -2,17 +2,19 @@ module Idv
   class ConsentForm
     include ActiveModel::Model
 
-    validates :idv_consent_given?,
+    attr_reader :idv_consent_given
+
+    validates :idv_consent_given,
               acceptance: { message: proc { I18n.t('errors.doc_auth.consent_form') } }
 
+    def initialize(idv_consent_given: false)
+      @idv_consent_given = idv_consent_given
+    end
+
     def submit(params)
       @idv_consent_given = params[:idv_consent_given] == '1'
 
       FormResponse.new(success: valid?, errors: errors)
     end
-
-    def idv_consent_given?
-      @idv_consent_given
-    end
   end
 end

app/services/idv/session.rb

@@ -143,6 +143,14 @@ def add_failed_phone_step_number(phone)
       failed_phone_step_numbers << phone_e164 if !failed_phone_step_numbers.include?(phone_e164)
     end
 
+    def has_pii_from_user_in_flow_session
+      user_session.dig('idv/in_person', :pii_from_user)
+    end
+
+    def document_capture_complete?
+      pii_from_doc || has_pii_from_user_in_flow_session || verify_info_step_complete?
+    end
+
     def verify_info_step_complete?
       resolution_successful
     end

app/views/idv/agreement/show.html.erb

@@ -17,7 +17,8 @@
 <p><%= t('doc_auth.info.secure_account') %></p>
 
 <%= simple_form_for(
-      :doc_auth,
+      @consent_form,
+      as: :doc_auth,
       url: url_for,
       method: 'put',
       html: { autocomplete: 'off', class: 'margin-top-2 margin-bottom-5 js-consent-continue-form' },

spec/controllers/concerns/idv_step_concern_spec.rb

@@ -34,6 +34,80 @@ def show
     end
   end
 
+  describe '#confirm_hybrid_handoff_needed' do
+    controller(idv_step_controller_class) do
+      before_action :confirm_hybrid_handoff_needed
+    end
+
+    before(:each) do
+      sign_in(user)
+      routes.draw do
+        get 'show' => 'anonymous#show'
+      end
+    end
+
+    context 'redo specified' do
+      it 'sets flag in idv_session' do
+        expect { get :show, params: { redo: true } }.to change {
+                                                          idv_session.redo_document_capture
+                                                        }.from(nil).to(true)
+      end
+
+      it 'does not redirect' do
+        get :show, params: { redo: true }
+        expect(response).to have_http_status(200)
+      end
+    end
+
+    context 'document capture complete' do
+      before do
+        idv_session.pii_from_doc = { first_name: 'Susan' }
+      end
+
+      it 'redirects to ssn screen' do
+        get :show
+        expect(response).to redirect_to(idv_ssn_url)
+      end
+
+      context 'and redo specified' do
+        it 'does not redirect' do
+          get :show, params: { redo: true }
+          expect(response).to have_http_status(200)
+        end
+      end
+    end
+
+    context 'previously skipped hybrid handoff' do
+      before do
+        idv_session.skip_hybrid_handoff = true
+        get :show
+      end
+
+      it 'sets flow_path to standard' do
+        expect(idv_session.flow_path).to eql('standard')
+      end
+
+      it 'redirects to document capture' do
+        expect(response).to redirect_to(idv_document_capture_url)
+      end
+    end
+
+    context 'hybrid flow not available' do
+      before do
+        allow(FeatureManagement).to receive(:idv_allow_hybrid_flow?).and_return(false)
+        get :show
+      end
+
+      it 'sets flow_path to standard' do
+        expect(idv_session.flow_path).to eql('standard')
+      end
+
+      it 'redirects to document capture' do
+        expect(response).to redirect_to(idv_document_capture_url)
+      end
+    end
+  end
+
   describe '#confirm_idv_needed' do
     controller(idv_step_controller_class) do
       before_action :confirm_idv_needed
@@ -132,6 +206,65 @@ def show
     end
   end
 
+  describe '#confirm_document_capture_not_complete' do
+    controller(idv_step_controller_class) do
+      before_action :confirm_document_capture_not_complete
+    end
+
+    before(:each) do
+      sign_in(user)
+      routes.draw do
+        get 'show' => 'anonymous#show'
+      end
+    end
+
+    context 'the user has not completed document capture' do
+      it 'does not redirect and renders the view' do
+        idv_session.pii_from_doc = nil
+        idv_session.resolution_successful = nil
+
+        get :show
+
+        expect(response.body).to eq('Hello')
+        expect(response.status).to eq(200)
+      end
+    end
+
+    context 'the user has completed remote document capture but not verify_info' do
+      it 'redirects to the ssn step' do
+        idv_session.pii_from_doc = { first_name: 'Susan' }
+        idv_session.resolution_successful = false
+
+        get :show
+
+        expect(response).to redirect_to(idv_ssn_url)
+      end
+    end
+
+    context 'the user has completed in person document capture but not verify_info' do
+      it 'redirects to the ssn step' do
+        subject.user_session['idv/in_person'] = {}
+        subject.user_session['idv/in_person'][:pii_from_user] = { first_name: 'Susan' }
+        idv_session.resolution_successful = false
+
+        get :show
+
+        expect(response).to redirect_to(idv_ssn_url)
+      end
+    end
+
+    context 'the user has completed document capture and verify_info' do
+      it 'redirects to the ssn step' do
+        idv_session.pii_from_doc = nil
+        idv_session.resolution_successful = true
+
+        get :show
+
+        expect(response).to redirect_to(idv_ssn_url)
+      end
+    end
+  end
+
   describe '#confirm_verify_info_step_complete' do
     controller(idv_step_controller_class) do
       before_action :confirm_verify_info_step_complete

spec/controllers/idv/agreement_controller_spec.rb

@@ -74,12 +74,23 @@
     end
 
     context 'agreement already visited' do
-      it 'redirects to hybrid_handoff' do
+      it 'does not redirect to hybrid_handoff' do
         allow(subject.idv_session).to receive(:idv_consent_given).and_return(true)
 
         get :show
 
-        expect(response).to redirect_to(idv_hybrid_handoff_url)
+        expect(response).to render_template('idv/agreement/show')
+      end
+    end
+
+    context 'and document capture already completed' do
+      before do
+        subject.idv_session.pii_from_doc = { first_name: 'Susan' }
+      end
+
+      it 'redirects to ssn step' do
+        get :show
+        expect(response).to redirect_to(idv_ssn_url)
       end
     end
   end

spec/controllers/idv/getting_started_controller_spec.rb

@@ -70,13 +70,14 @@
       )
     end
 
-    context 'getting_started already visited' do
-      it 'redirects to hybrid_handoff' do
-        subject.idv_session.idv_consent_given = true
+    context 'document capture already completed' do
+      before do
+        subject.idv_session.pii_from_doc = { first_name: 'Susan' }
+      end
 
+      it 'redirects to ssn step' do
         get :show
-
-        expect(response).to redirect_to(idv_hybrid_handoff_url)
+        expect(response).to redirect_to(idv_ssn_url)
       end
     end
 

spec/controllers/idv/hybrid_handoff_controller_spec.rb

@@ -104,15 +104,15 @@
 
         get :show
 
-        expect(response).to redirect_to(idv_document_capture_url)
+        expect(response).to render_template :show
       end
 
       it 'redirects to link_sent in hybrid flow' do
         subject.idv_session.flow_path = 'hybrid'
 
         get :show
 
-        expect(response).to redirect_to(idv_link_sent_url)
+        expect(response).to render_template :show
       end
     end