Remove unused USWDS utilities, fonts, components#9290
Merged
Conversation
changelog: Internal, Performance, Reduce size of application stylesheet
zachmargolis
approved these changes
Sep 29, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
Removes a few unused items from the design system:
Impact:
Not quite as dramatic as I'd hoped! Probably because there's a lot of repetition in what's being removed, which Brotli is quite good at optimizing.
Before: 26.4kb
After: 26kb
Diff: -0.4kb (-1.5%)
📜 Testing Plan
Verify no visual regressions.
To verify which classes are being removed here, I created a simplified stylesheet to render just these parts of USWDS:
Relevant output:
Click to expand