Skip to content

Rename ial2_consent_given (3/3) #9288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
matthinz merged 1 commit into from
Oct 6, 2023
Merged

Rename ial2_consent_given (3/3) #9288

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/controllers/idv/agreement_controller.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ def skip_to_capture
end

def consent_form_params
params.require(:doc_auth).permit([:ial2_consent_given, :idv_consent_given])
params.require(:doc_auth).permit(:idv_consent_given)
end

def confirm_welcome_step_complete
Expand Down
2 changes: 1 addition & 1 deletion app/controllers/idv/getting_started_controller.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ def skip_to_capture
end

def consent_form_params
params.require(:doc_auth).permit([:ial2_consent_given, :idv_consent_given])
params.require(:doc_auth).permit(:idv_consent_given)
end

def confirm_agreement_needed
Expand Down
2 changes: 1 addition & 1 deletion app/forms/idv/consent_form.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ class ConsentForm
acceptance: { message: proc { I18n.t('errors.doc_auth.consent_form') } }

def submit(params)
@idv_consent_given = params[:idv_consent_given] == '1' || params[:ial2_consent_given] == '1'
@idv_consent_given = params[:idv_consent_given] == '1'

FormResponse.new(success: valid?, errors: errors)
end
Expand Down
15 changes: 0 additions & 15 deletions spec/controllers/idv/agreement_controller_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,20 +145,5 @@
expect(response).to redirect_to(idv_hybrid_handoff_url)
end
end

context 'ial2_consent_given param present' do
let(:params) do
{
doc_auth: {
ial2_consent_given: 1,
},
skip_hybrid_handoff: skip_hybrid_handoff,
}.compact
end
it 'succeeds' do
put :update, params: params
expect(response).to redirect_to(idv_hybrid_handoff_url)
end
end
end
end
15 changes: 0 additions & 15 deletions spec/controllers/idv/getting_started_controller_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,21 +155,6 @@
expect(response).to redirect_to(idv_hybrid_handoff_url)
end

context 'ial2_consent_given param present' do
let(:params) do
{
doc_auth: {
ial2_consent_given: 1,
},
skip_hybrid_handoff: skip_hybrid_handoff,
}.compact
end
it 'succeeds' do
put :update, params: params
expect(response).to redirect_to(idv_hybrid_handoff_url)
end
end

context 'skip_hybrid_handoff present in params' do
let(:skip_hybrid_handoff) { '' }
it 'sets flow_path to standard' do
Expand Down