LG-11035: Do you have a phone to take photos IdV page

[amirbey]

🎫 Ticket

LG-11035
LG-11078
LG-11079

🛠 Summary of changes

Create route, controller and view of page to ask a user if they have a phone that can take photos

📜 Testing Plan

• visit localhost:3000/verify/phone_question

👀 Screenshots

[soniaconnolly]

LGTM! I tried it out and it renders when I'm in the right place in the flow, and when I put the browser in mobile mode it skipped this view as well as HybridHandoff. Cancel works as expected. This should be good in the 50/50 state since nothing uses the routes yet.

Couple of coding comments.

[soniaconnolly]

Would it work to move HybridHandoffController#confirm_hybrid_handoff_needed to IdvStepConcern and share it between the two controllers? I'm uneasy about the pattern of making the same checks, and then redirecting to HybridHandoff to let it redirect again. It's confusing code, which is okay if very temporary, but it also makes it more likely to run up against the limit of 10 redirects before the user gets a "too many redirects" failure.

[soniaconnolly]

I had to think about why this is here and in HybridHandoffController. I think it's because we delete pii_from_doc from the session after the VerifyInfo step, so we need to make sure they're not past that step when they land here.

[amirbey]

yep ... after verify info accessing pii is ☹️ LG-10603

[soniaconnolly]

Could consider adding a spec for the cancel link. Not sure the additional spec would add value or not.

[kellular]

LGTM! I had two comments about adding commas for French and Spanish. (I originally left the comma out of the English text "Yes I have a phone" because I thought it sounded overly formal, but I checked other places we use "Yes..." statements and the comma is included so thanks for adding that in the English text here!).

[kellular]

Nit: Could you add a comma after "Sí"?

[kellular]

Nit: Could you add a comma after "Oui"?

[amirbey]

yeah, i had asked myself the same question 🤔 but after checking how we translate across the site, not using the comma after yes/no is the pattern we use everywhere else

[aduth]

If the title never changes, could we have just inlined the text to avoid the indirection?

Suggested change

	<% title @title %>
	<% title t('doc_auth.headings.phone_question') %>