Skip to content

LG-10912 Adjust send condition to manage by config #9284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ThatSpaceGuy merged 1 commit into from
Sep 28, 2023
Merged

LG-10912 Adjust send condition to manage by config #9284

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/jobs/reports/monthly_key_metrics_report.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ def perform(date)

def emails
emails = [IdentityConfig.store.team_agnes_email]
if Identity::Hostdata.env == 'prod' && report_date.day == 1
if report_date.day == 1
emails << IdentityConfig.store.team_all_feds_email
end
emails
Expand Down
1 change: 0 additions & 1 deletion spec/jobs/reports/monthly_key_metrics_report_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@
and_return(agnes_email)
allow(IdentityConfig.store).to receive(:team_all_feds_email).
and_return(feds_email)
allow(Identity::Hostdata).to receive(:env).and_return('prod')
end

it 'sends out a report to the email listed with one total user' do
Expand Down