Add phone question a_b variable

[charleyf]

🎫 Ticket

https://cm-jira.usa.gov/browse/LG-11090

🛠 Summary of changes

This work is intentionally small: Adding a new a_b testing variable, but not to using it yet.

When Sonia did this for team Ada (link) she included the variable addition in the PR that used it.

📜 Testing Plan

An engineer could make sure that the variable shows up by using the rails console? I'm not sure if that's necessary?

[night-jellyfish]

I am probably doing something wrong, but when I try running:

IdentityConfig.store.idv_phone_question_a_b_testing in the Rails console, I get NoMethodError: undefined method 'idv_phone_question_a_b_testing'

When I try other values from this file and from the PR linked from this one, I see a return value.

I tried make setup && make run on this branch first to make sure the changes were applied.

I'm probably doing something wrong, but I wanted to note it here since it was the testing plan and I'd be happy to learn how to make it work locally for me.

[aduth]

It needs to be added to the list of configuration values in the IdentityConfig store for it to be accessible in code that way.

[charleyf]

Thank you both, added the new variable there (commit).

[night-jellyfish]

@aduth when you say that change is needed to be accessible in code that way - is there a case where you wouldn't need to add it in both places?

@charleyf Thank you for making that change! I tested it again with the changes and saw the expected value in the console.

[aduth]

@aduth when you say that change is needed to be accessible in code that way - is there a case where you wouldn't need to add it in both places?

Typically it should always be in both places. Since this ticket was already very limited in usefulness on its own, I wasn't sure just how far it was meant to be completed to be considered "functional".

[night-jellyfish]

Tested in the Rails console and saw the expected value.