Skip to content

Force refresh the page on third image permission denied#9260

Merged
charleyf merged 5 commits intomainfrom
charley/reload-on-third-permission-deny
Oct 2, 2023
Merged

Force refresh the page on third image permission denied#9260
charleyf merged 5 commits intomainfrom
charley/reload-on-third-permission-deny

Conversation

@charleyf
Copy link
Contributor

🎫 Ticket

https://cm-jira.usa.gov/browse/LG-10984

🛠 Summary of changes

This force refreshes the page on the third time you get a permission denied error. It's not a good user experience, but it is better than what was happening (clicking the upload area and nothing happens).

👀 Screenshots

If relevant, include a screenshot or screen capture of the changes.

After:
with-forced-refresh.mov

@charleyf charleyf marked this pull request as ready for review September 27, 2023 14:36
@charleyf charleyf requested review from a team and night-jellyfish and removed request for a team September 29, 2023 14:39

// Due to a bug with Safari on iOS we force the page to refresh on the third
// time a user denies permissions.
onFailedCameraPermissionAttempt();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I posted this in Slack, but realized I probably should have posted it here instead (with a couple of edits for clarity).

I've tested this branch out locally, and I see something that I'm not sure is intended behavior, or perhaps I'm misinterpreting text. It does look like this behavior is in the video provided, so it's probably me missing something.

With "after permissions being denied three times", I expected the page refresh to happen after I hit cancel on the the third try. But really, after I hit the "front of your license" button area 3x, saw the error message, and then I hit the "front of your license" button area for a 4th time, that is when it refreshes.

It feels a little jarring to me for that to be the timing, but maybe that's just me and this is behavior as intended.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for mentioning this, it is jarring. I think we want to proceed as is.

  • This should not be happening for too many folks.
  • This is a mitigation, we aren't able to truly fix the issue, so we're trying to unblock users which this achieves.
    It would be nice to revisit this at a later date and clean it up, but for now I think "users don't get stuck" is achieved in this PR.

@eileen-nava eileen-nava requested a review from kellular October 2, 2023 15:48
@charleyf charleyf merged commit 08da514 into main Oct 2, 2023
@charleyf charleyf deleted the charley/reload-on-third-permission-deny branch October 2, 2023 18:43
@jmhooper jmhooper mentioned this pull request Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants