Skip to content

LG-11001: Mark i18n as peerDependency in certain @18f/identity- packages #9257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
allthesignals merged 2 commits into from
Sep 25, 2023
Merged

LG-11001: Mark i18n as peerDependency in certain @18f/identity- packages #9257

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1668e5d
changelog: Internal, In-Person Proofing, Make i18n a peer dep
allthesignals Sep 25, 2023
a5abd0e
Merge branch 'main' of https://github.com/18F/identity-idp into wmg/1…
allthesignals Sep 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions app/javascript/packages/address-search/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,8 @@ npm install @18f/identity-address-search

Requires React version 17 or greater.

Requires @18f/identity-i18n.

## Usage

To use this component, provide callbacks to it for desired behaviors.
Expand Down
5 changes: 3 additions & 2 deletions app/javascript/packages/address-search/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@18f/identity-address-search",
"version": "2.4.0",
"version": "3.0.0",
"type": "module",
"private": false,
"files": [
Expand All @@ -25,7 +25,8 @@
"swr": "^2.0.0"
},
"peerDependencies": {
"react": ">=17"
"react": ">=17",
"@18f/identity-i18n": ">=1"
},
"repository": {
"type": "git",
Expand Down
2 changes: 1 addition & 1 deletion app/javascript/packages/address-search/webpack.config.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ module.exports = /** @type {import('webpack').Configuration} */ ({
extensions: ['.js', '.jsx', '.ts', '.tsx', '.mjs', '.cjs', '.mts', '.cts'],
conditionNames: ['source'],
},
externals: /^(?!(@18f\/identity-|\.))/,
externals: [/^(?!(@18f\/identity-|\.))/, '@18f/identity-i18n'],
Copy link
Copy Markdown
Contributor Author

@allthesignals allthesignals Sep 25, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really love the way this is set up... we would need to get Webpack to distinguish between packages that are available via workspaces and packages that are published on the npm registry. Otherwise, we are left explicitly specifying this....

module: {
rules: [
{
Expand Down
5 changes: 3 additions & 2 deletions app/javascript/packages/components/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@18f/identity-components",
"version": "1.0.0-beta0.2",
"version": "2.0.0",
"type": "module",
"private": false,
"files": [
Expand All @@ -25,7 +25,8 @@
},
"peerDependencies": {
"react": ">=17",
"react-dom": ">=17"
"react-dom": ">=17",
"@18f/identity-i18n": ">=1"
},
"repository": {
"type": "git",
Expand Down
2 changes: 1 addition & 1 deletion app/javascript/packages/components/webpack.config.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ module.exports = /** @type {import('webpack').Configuration} */ ({
extensions: ['.js', '.jsx', '.ts', '.tsx', '.mjs', '.cjs', '.mts', '.cts'],
conditionNames: ['source'],
},
externals: /^(?!(@18f\/identity-|\.))/,
externals: [/^(?!(@18f\/identity-|\.))/, '@18f/identity-i18n'],
module: {
rules: [
{
Expand Down