Skip to content

Fix identity verification session error tests to use the correct rate limiter #9222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mitchellhenke merged 1 commit into from
Sep 15, 2023
Merged

Fix identity verification session error tests to use the correct rate limiter #9222

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions spec/controllers/idv/session_errors_controller_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,7 @@
let(:user) { create(:user) }

before do
RateLimiter.new(rate_limit_type: :proof_address, user: user).increment!
RateLimiter.new(rate_limit_type: :idv_resolution, user: user).increment!
end

it 'assigns remaining count' do
Expand All @@ -180,7 +180,7 @@
'IdV: session error visited',
hash_including(
type: action.to_s,
attempts_remaining: 5,
attempts_remaining: IdentityConfig.store.idv_max_attempts - 1,
),
)
response
Expand Down Expand Up @@ -236,7 +236,7 @@
let(:user) { create(:user) }

before do
RateLimiter.new(rate_limit_type: :proof_address, user: user).increment_to_limited!
RateLimiter.new(rate_limit_type: :idv_resolution, user: user).increment_to_limited!
end

it 'assigns expiration time' do
Expand All @@ -258,7 +258,7 @@
'IdV: session error visited',
hash_including(
type: action.to_s,
attempts_remaining: 5,
attempts_remaining: 0,
),
)
get action
Expand Down