Skip to content

LG-10273 idv_session cleanup - remove unused properties #9178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
soniaconnolly merged 2 commits into from
Sep 8, 2023
Merged

LG-10273 idv_session cleanup - remove unused properties #9178

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0f7c5cf
Remove unused profile_step_params from idv_session
soniaconnolly Sep 8, 2023
81d485d
Remove unused profile_confirmation from idv_session
soniaconnolly Sep 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions app/services/idv/session.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,7 @@ class Session
phone_for_mobile_flow
pii
previous_phone_step_params
profile_confirmation
profile_id
profile_step_params
redo_document_capture
resolution_successful
skip_hybrid_handoff
Expand Down Expand Up @@ -186,16 +184,10 @@ def clear_applicant!

def mark_verify_info_step_complete!
session[:resolution_successful] = true
# This is here to maintain backwards compadibility with old code.
# Once the code that checks `profile_confirmation` is removed from prod
# this setter and eventually the value in the Idv::Session struct itself
# can be removed.
session[:profile_confirmation] = true
end

def invalidate_verify_info_step!
session[:resolution_successful] = nil
session[:profile_confirmation] = nil
end

def invalidate_steps_after_verify_info!
Expand Down