Skip to content

Identity Verification report job to immediately exit when s3 reports are disabled #9175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
amirbey merged 2 commits into from
Sep 8, 2023
Merged

Identity Verification report job to immediately exit when s3 reports are disabled #9175

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e336d59
when s3 reports disabled, Identity verification report to return imme…
amirbey Sep 8, 2023
a963c14
[skip changelog]
amirbey Sep 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions app/jobs/reports/identity_verification_report.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ class IdentityVerificationReport < BaseReport
attr_accessor :report_date

def perform(report_date)
return unless IdentityConfig.store.s3_reports_enabled
self.report_date = report_date

csv = report_maker.to_csv
Expand Down
4 changes: 4 additions & 0 deletions spec/jobs/reports/identity_verification_report_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,10 @@
require 'rails_helper'

RSpec.describe Reports::IdentityVerificationReport do
before do
allow(IdentityConfig.store).to receive(:s3_reports_enabled).and_return(true)
end

describe '#perform' do
it 'gets a CSV from the report maker and saves it to S3' do
report_maker = double(Reporting::IdentityVerificationReport, to_csv: 'I am a CSV, see')
Expand Down