Skip to content

Memoize options method on TwoFactorLoginOptionsPresenter #9173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mitchellhenke merged 1 commit into from
Sep 8, 2023
Merged

Memoize options method on TwoFactorLoginOptionsPresenter #9173

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion app/presenters/two_factor_login_options_presenter.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ def restricted_options_warning_text
end

def options
return @options if defined?(@options)
mfa = MfaContext.new(user)

if @piv_cac_required
Expand All @@ -63,7 +64,9 @@ def options
# webauthn keys and phones. However, we only want to show one of each option
# during login, except for phones, where we want to allow the user to choose
# which MFA-enabled phone they want to use.
configurations.group_by(&:class).flat_map { |klass, set| klass.selection_presenters(set) }
@options = configurations.group_by(&:class).flat_map do |klass, set|
klass.selection_presenters(set)
end
end

def account_reset_or_cancel_link
Expand Down