10787: Extract hook from Full Address Search

[allthesignals]

🎫 Ticket

🛠 Summary of changes

Partly addresses the ticket by extracting the hook into a separate file. This will make it easier to combine components later.

📜 Testing Plan

• Behavior should remain the same as before. This is a small refactor.

[aduth]

Seems like it'd be a good opportunity to add some test coverage?

[gina-yamada]

Sorry for the slow approval! I just got my local env working to test this out. Behavior working as before- was able to hit usps locally and get display, form validation working - LGMT

[allthesignals]

Seems like it'd be a good opportunity to add some test coverage?

Sure. There is coverage for this feature but I could add a unit test for the hook, unless I'm missing something else

[allthesignals]

Seems like it'd be a good opportunity to add some test coverage?

Also have we ever had a way to measure code coverage on this project? A CI report would be great.

[aduth]

Also have we ever had a way to measure code coverage on this project? A CI report would be great.

We have test coverage between CodeClimate (example) and GitLab "coverage" step (example), but I don't know that this has given an accurate representation of coverage of anything other than Ruby code. I think it'd be a good idea to see if we could extend this.

[aduth]

Thanks for adding the tests 🎉

[allthesignals]

Also have we ever had a way to measure code coverage on this project? A CI report would be great.

We have test coverage between CodeClimate (example) and GitLab "coverage" step (example), but I don't know that this has given an accurate representation of coverage of anything other than Ruby code. I think it'd be a good idea to see if we could extend this.

Happy to look into this. Seems like there's some configuration alluding to JS in Code Climate YAML file, but the dashboard itself doesn't report anything about the JS.