Skip to content

Fix Face/Touch "Learn more" grammar for French/Spanish#9161

Merged
aduth merged 1 commit intomainfrom
aduth-ft-learn-more-grammar
Sep 8, 2023
Merged

Fix Face/Touch "Learn more" grammar for French/Spanish#9161
aduth merged 1 commit intomainfrom
aduth-ft-learn-more-grammar

Conversation

@aduth
Copy link
Contributor

@aduth aduth commented Sep 7, 2023

🎫 Ticket

Noticed during LG-10871 (#9155)

🛠 Summary of changes

Updates the Face or Touch Unlock setup screen texts to ensure consistent sentence grammar across all languages.

Before:

  • English: Two sentences with a space between
  • French: Two sentences, no space between
  • Spanish: One run-on sentence

After: All are two sentences with a space between

📜 Testing Plan

  1. Go to http://localhost:3000
  2. Sign in or create an account
  3. When given the opportunity to add a new MFA method, add a new Face or Touch Unlock authenticator
  4. Observe the link in the second paragraph
  5. Change the language
  6. Notice the grammar is consistent across languages

👀 Screenshots

Language Before After
English Screenshot 2023-09-07 at 8 42 47 AM Screenshot 2023-09-07 at 8 42 47 AM
Spanish Screenshot 2023-09-07 at 8 42 35 AM Screenshot 2023-09-07 at 8 43 10 AM
French Screenshot 2023-09-07 at 8 42 50 AM Screenshot 2023-09-07 at 8 43 03 AM

changelog: Upcoming Features, Face or Touch Unlock, Fix grammar for translated paragraph sentences
@aduth aduth requested a review from a team September 7, 2023 12:53
@aduth aduth merged commit 4852aed into main Sep 8, 2023
@aduth aduth deleted the aduth-ft-learn-more-grammar branch September 8, 2023 19:58
@aduth aduth mentioned this pull request Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants