Fix Acuant Error Handler Function Naming#9149
Merged
Conversation
eileen-nava
reviewed
Sep 6, 2023
Contributor
eileen-nava
left a comment
There was a problem hiding this comment.
This worked when I tested it locally! Below I uploaded a video of me locally testing it. Thanks, Charley! 🎉 (I am also going to request that another @18F/identity-timnit-engineers team member review it, to be thorough.)
SDkBugFixWorked.mov
@charleyf Could you please fix the tests that broke due to the change from onFailure to onError, like the acuant capture jsx tests? Thanks!
Contributor
night-jellyfish
left a comment
There was a problem hiding this comment.
I tested both before and after the changes and saw the expected difference! 🎉 I will approve once CI passes.
… camera permissions denied during document upload
night-jellyfish
approved these changes
Sep 6, 2023
Contributor
night-jellyfish
left a comment
There was a problem hiding this comment.
Thank you for fixing the tests!
eileen-nava
approved these changes
Sep 6, 2023
Contributor
eileen-nava
left a comment
There was a problem hiding this comment.
Thanks for fixing this! 💯
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
https://cm-jira.usa.gov/browse/LG-10900
🛠 Summary of changes
This work changes the name of an error handling function to what the AcuantSDK expects.
📜 Testing Plan
Extracted from the slack thread about this bug here.
11.8.2to test that version only.👀 Screenshots
If relevant, include a screenshot or screen capture of the changes.
Camera permissions popup
Before: White screen with X in the corner
After: Error message