Update IDV report to support multiple issuers (LG-10875)#9148
Merged
zachmargolis merged 5 commits intomainfrom Sep 6, 2023
Merged
Update IDV report to support multiple issuers (LG-10875)#9148zachmargolis merged 5 commits intomainfrom
zachmargolis merged 5 commits intomainfrom
Conversation
- Expanding use so we can support a specific one-off request, but seemed easier to expand all reports at once
changelog: Internal, Reporting, Update funnel reports to accept multiple issuers
mitchellhenke
approved these changes
Sep 6, 2023
olatifflexion
approved these changes
Sep 6, 2023
n1zyy
reviewed
Sep 6, 2023
| name | ||
| , properties.user_id AS user_id | ||
| | filter properties.service_provider = %{issuer} | ||
| | filter properties.service_provider IN %{issuers} |
Contributor
There was a problem hiding this comment.
Just confirming: Does using an array here just intrinsically work? Without looking through the parser code I would have guessed we had to .join(', ') here. I'm inferring (based on tests) that it gets evaluated by a smarter parser.
Contributor
Author
There was a problem hiding this comment.
Good question! It's the call to quote() above that formats it as an array
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(tagging Ursula and Ada since sometimes these reports are relevant to those teams, especially the background job version)