Fix behavior for PIV/CAC declined setup from sign-in#9146
Merged
Conversation
zachmargolis
approved these changes
Sep 5, 2023
mdiarra3
approved these changes
Sep 7, 2023
changelog: Bug Fixes, PIV CAC Sign-In, Fix issue preventing user from being redirected to partner after declined PIV/CAC setup from sign-in
fa8144d to
4e89766
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
Ensures that when the user opts to decline the option to set up a PIV/CAC authenticator after attempting to sign in with it without having first linked an account, the user arrives at the correct place. Previously, the user would arrive at their account dashboard, even if they had started from a partner application.
Before these changes, the existing controller action for
Users::PivCacSetupFromSignInController#declineis unused.📜 Testing Plan
Easiest to test with PIV/CAC simulator in local development. In
config/application.yml:Before: You'd be redirected to your account page, with a link to "Continue to [SP]"
After: Depending if you've already granted consent for the SP, you're either redirected back to the SP or prompted to agree and continue
👀 Screenshots
Setup screen: