LG-10530: Improve Verify by Mail controller & route names#9136

Merged

matthinz merged 34 commits intomainfrom

matthinz/10530-nobody-knows-what-gpo-is

Sep 8, 2023

Commits on Sep 8, 2023

Move GPO controllers into by_mail and rename
matthinz
committed
Move GPO controller specs into by_mail and rename
matthinz
committed
Get RequestLetterController spec passing
matthinz
committed
Get LetterEnqueuedController spec passing
matthinz
committed
Get EnterCodeController spec passing
matthinz
committed
come_back_later -> letter_enqueued
matthinz
committed
Update view specs
matthinz
committed
Analytics event naming
matthinz
committed
Rename some routes and add temporary redirects
matthinz
committed
'come back later visited' -> 'letter enqueued visited'
matthinz
committed
idv_letter_enqueued -> idv_gpo_letter_enqueued
matthinz
committed
/by_mail -> /by_mail/enter_code
matthinz
committed
Fix GpoPresenter spec
matthinz
committed
'USPS address visited' -> 'gpo request letter visited'
matthinz
committed
letter enqueued visited -> gpo letter enqueued visited'
matthinz
committed
`IdV: GPO verification visited` -> `IdV: gpo enter code visited`
matthinz
committed
enter code -> enter verify by mail code
matthinz
committed
'GPO verification submitted' -> 'enter verify by mail code submitted'
matthinz
committed
Remove GPO from a couple of analytics event names
matthinz
committed
Clarify temporary redirects
matthinz
committed
Update app/services/analytics_events.rb

matthinz
and
soniaconnolly
committed
idv_gpo_url -> idv_request_letter_url
matthinz
committed
idv_gpo_letter_enqueued_url -> idv_letter_enqueued_url
matthinz
committed
idv_gpo_verify_url -> idv_enter_verify_by_mail_code_path
matthinz
committed
idv_gpo_url fixup
matthinz
committed
fixup idv_gpo_verify_url
matthinz
committed
Idv::GpoPresenter -> Idv::ByMail::RequestLetterPresenter
matthinz
committed
A couple of analytics methods
matthinz
committed
Fix test
matthinz
committed
idv_enter_verify_by_mail_code_url -> idv_verify_by_mail_enter_code_url
matthinz
committed
Don't change routes yet
matthinz
committed
Fix presenter spec
matthinz
committed
Update analytics method name
matthinz
committed
Add PUT/POST routes for new GPO locations
matthinz
committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

LG-10530: Improve Verify by Mail controller & route names#9136

LG-10530: Improve Verify by Mail controller & route names#9136
matthinz merged 34 commits intomainfrom
matthinz/10530-nobody-knows-what-gpo-is

Commits on Sep 8, 2023

Move GPO controllers into by_mail and rename

Move GPO controller specs into by_mail and rename

Get RequestLetterController spec passing

Get LetterEnqueuedController spec passing

Get EnterCodeController spec passing

come_back_later -> letter_enqueued

Update view specs

Analytics event naming

Rename some routes and add temporary redirects

'come back later visited' -> 'letter enqueued visited'

idv_letter_enqueued -> idv_gpo_letter_enqueued

/by_mail -> /by_mail/enter_code

Fix GpoPresenter spec

'USPS address visited' -> 'gpo request letter visited'

letter enqueued visited -> gpo letter enqueued visited'

`IdV: GPO verification visited` -> `IdV: gpo enter code visited`

enter code -> enter verify by mail code

'GPO verification submitted' -> 'enter verify by mail code submitted'

Remove GPO from a couple of analytics event names

Clarify temporary redirects

Update app/services/analytics_events.rb

idv_gpo_url -> idv_request_letter_url

idv_gpo_letter_enqueued_url -> idv_letter_enqueued_url

idv_gpo_verify_url -> idv_enter_verify_by_mail_code_path

idv_gpo_url fixup

fixup idv_gpo_verify_url

Idv::GpoPresenter -> Idv::ByMail::RequestLetterPresenter

A couple of analytics methods

Fix test

idv_enter_verify_by_mail_code_url -> idv_verify_by_mail_enter_code_url

Don't change routes yet

Fix presenter spec

Update analytics method name

Add PUT/POST routes for new GPO locations